[lwip-devel] [bug #20287] tcp_output_nagle sends too early

[Simon Goldschmidt]

Follow-up Comment #7, bug #20287 (project lwip):

- As a first fix, I've added a check that snd_queuelen doesn't overflow. I'm
still checking if it needs to be converted to u16_t.

- I figured tcp_output_nagle does still send too much data: if 2 segments are
enqueued (e.g. one of size==mss, the other has only 12 bytes), both segments
will be sent by tcp_enqueue. Thus, it is necessarry to have the nagle check
inside the last while-loop in tcp_output also.

Any objections about that? It would only get active if TF_NODELAY is not set,
so we would have a real implementation of the nagle algorithm that is on all
the time until disabled (even for raw api).

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?20287>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.nongnu.org/