[lwip-devel] [bug #20287] tcp_output_nagle sends too early

[Simon Goldschmidt]

Follow-up Comment #6, bug #20287 (project lwip):

The new algorithm performs much better.

Because small chunks are put together to form bigger segments more often, the
tcp_pcb->snd_queuelen is more possible to overflow now, however.

There is some incosistency about the snd_queuelen variable, anyway: one time
it is referred to as 'the total number of pbufs for this segment', another
time with 'update number of segments on the queues'. I think the number of
pbufs makes more sense to configure for small systems, but overflowing should
be checked (not only with an assert, can happen in runtime environments,
also).

And we _should_ convert snd_buflen to an u16_t: if you have a send-buffer of
32KBytes and want fill that up with many small pbufs, you easily get more
than 255 pbufs in that chain!

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?20287>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.nongnu.org/