[lwip-devel] [task #6930] Implement SO_LINGER

[Simon Goldschmidt]

Follow-up Comment #12, task #6930 (project lwip):

Re comment #10:

> netconn_close/do_close now just do a tcp_close for NETCONN_TCP,
> and return ERR_VAL for the other

Yes, ERR_OK might be better for other types.

>  do you want or not to call netconn_close (and also
> netconn_delete) in lwip_close (it's not in your patch)?

netconn_delete is definitely needed in lwip_close. since it already calls
tcp_close, netconn_close is not needed, I think.

But my patch isn't correct after reading Magnus Berglund's post. Waiting for
tcp_close returning ERR_OK is definitely needed. I would handle it by not
acknowledging in do_close and call tcp_close again from sent_tcp or poll_tcp.
That way, we both avoid the loop in netconn_close and the need for conn->sem
(faster, less context-switches, no race conditions).

I'll prepare a patch.

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/task/?6930>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.nongnu.org/