[lwip-devel] [bug #20259] udp.h/udp_hdr struct definition incorrect

[Thomas Taranowski]

URL:
  <http://savannah.nongnu.org/bugs/?20259>

                 Summary: udp.h/udp_hdr struct definition incorrect
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: taranowski
            Submitted on: Monday 06/25/2007 at 20:53
                Category: UDP
                Severity: 3 - Normal
              Item Group: Faulty Behaviour
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

Patch attached.

The definition of the udp_hdr struct does not include the correct packing
pre/postamble.

+
 /* Fields are (of course) in network byte order. */
+#ifdef PACK_STRUCT_USE_INCLUDES
+#  include "arch/bpstruct.h"
+#endif
+PACK_STRUCT_BEGIN
 struct udp_hdr {
   PACK_STRUCT_FIELD(u16_t src);
   PACK_STRUCT_FIELD(u16_t dest);  /* src/dest UDP ports */
   PACK_STRUCT_FIELD(u16_t len);
   PACK_STRUCT_FIELD(u16_t chksum);
 } PACK_STRUCT_STRUCT;
+PACK_STRUCT_END
+#ifdef PACK_STRUCT_USE_INCLUDES
+#  include "arch/epstruct.h"
+#endif



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Monday 06/25/2007 at 20:53  Name: udp.packed.patch  Size: 829B   By:
taranowski

<http://savannah.nongnu.org/bugs/download.php?file_id=13165>

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?20259>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/