RE : RE : [lwip-devel] Move the nagle algorithm to core instead of api

[Frédéric BERNON]

But if people want to enable/disable it, they just have to unset/set the 
TF_NODELAY flags, right? And that's what socket layer users do what 
setsockopt(...TCP_NODELAY...). Adding a wrapper will add a - little - overhead 
to each "write" call...
  
====================================
Frédéric BERNON 
HYMATOM SA 
Chef de projet informatique 
Microsoft Certified Professional 
Tél. : +33 (0)4-67-87-61-10 
Fax. : +33 (0)4-67-70-85-44 
Email : address@hidden 
Web Site : http://www.hymatom.fr 
====================================
P Avant d'imprimer, penser à l'environnement
 


-----Message d'origine-----
De : address@hidden [mailto:address@hidden De la part de Kieran Mansley
Envoyé : mercredi 20 juin 2007 09:46
À : lwip-devel
Objet : Re: RE : [lwip-devel] Move the nagle algorithm to core instead of api


On Wed, 2007-06-20 at 09:41 +0200, Frédéric BERNON wrote:
> Why doesn't directly change tcp_write to include this part :
>  
> 
> if(err == ERR_OK && (msg->conn->pcb.tcp->unacked == NULL ||
> 
> (msg->conn->pcb.tcp->flags & TF_NODELAY) ||
> 
> (msg->conn->pcb.tcp->snd_queuelen) > 1)) {
> 
> err = tcp_output(msg->conn->pcb.tcp);
> 
> }
> 
> 
> Without adding any function?

I like Simon's idea of adding a wrapper function.  Often people want to avoid 
or disable the nagle algorithm and that will provide a nice neat way of doing 
it.

Kieran



_______________________________________________
lwip-devel mailing list
address@hidden http://lists.nongnu.org/mailman/listinfo/lwip-devel

Frédéric BERNON.vcf
Description: Frédéric BERNON.vcf