RE : [lwip-devel] Move the nagle algorithm to core instead of api

[Frédéric BERNON]

Why doesn't directly change tcp_write to include this part :

 

if(err == ERR_OK && (msg->conn->pcb.tcp->unacked == NULL ||

(msg->conn->pcb.tcp->flags & TF_NODELAY) ||

(msg->conn->pcb.tcp->snd_queuelen) > 1)) {

err = tcp_output(msg->conn->pcb.tcp);

}

Without adding any function? ok, it change a little bit the specification of the function, but it avoid a new function, and it's more packaged. And it will not really increase the footprint...

 

 

====================================
Frédéric BERNON
HYMATOM SA
Chef de projet informatique
Microsoft Certified Professional
Tél. : +33 (0)4-67-87-61-10
Fax. : +33 (0)4-67-70-85-44
Email : address@hiddenr
Web Site : http://www.hymatom.fr
====================================

P Avant d'imprimer, penser à l'environnement

 

-----Message d'origine-----
De : address@hidden [mailto:address@hidden De la part de Thomas Taranowski
Envoyé : mardi 19 juin 2007 20:43
À : lwip-devel
Objet : Re: [lwip-devel] Move the nagle algorithm to core instead of api

That looks like a nice clean solution to me.  I'm guessing the only reason it wasn't put there in the first place, is the developer of the socket library didn't want to muck around with the core code.

On 6/19/07, Goldschmidt Simon <address@hidden> wrote:

Shouldn't callback api apps also be able to use the nagle algorithm? Currently, we have it implemented in do_write(), which eventually calls tcp_output().

If we create a function/define tcp_nagle_output(tcp_pcb), and include all those if's and the call to tcp_output() in that function, core apps could call tcp_nagle_output instead of tcp_output and also have nagle support.

Any thoughts?


Simon

_______________________________________________
lwip-devel mailing list
address@hidden
http://lists.nongnu.org/mailman/listinfo/lwip-devel

Frédéric BERNON.vcf
Description: Frédéric BERNON.vcf