[lwip-devel] [patch #5914] Move sockopt processing into tcpip_thread

[Frédéric Bernon]

Follow-up Comment #27, patch #5914 (project lwip):

Sorry, I don't have find time for that. More, I think it will be so simple in
the future socket layer (using the global mutex).

But even if it's closed, if I can propose you an alternative... The general
idea is to add in struct api_msg_msg, a new substruct "opt" in the union :

struct api_msg_msg {
  struct netconn *conn;
  union {
    /* ... */
    struct { 
      int s;
      int level;
      int optname;
      void *optval;
      socklen_t *optlen;      
    } opt; /* options */
  } msg;
};

it's enable to use tcpip_apimsg, like all others functions. Another
possibility is to replace by the "union msg" by a "void * arg" to avoid to
extend the api_msg_msg for each message type...

Another thing I don't like with that, is the fact to have to communicate with
tcpip_thread just for set options. If you have to create a socket with 3 or 4
options, do a sendto, and close it, it's a little bit longer (and we know
that each exchange with tcpip_thread have a real cost...). 

But with the future socket layer... ;)


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?5914>

_______________________________________________
  Message posté via/par Savannah
  http://savannah.nongnu.org/