[lmi-commits] [lmi] master 6a5c4bb3 21/24: Distinguish gcc vs. clang floating-point warnings

[Greg Chicares]

branch: master
commit 6a5c4bb33b1919d59f523a703e8e7e23788048ab
Author: Gregory W. Chicares <gchicares@sbcglobal.net>
Commit: Gregory W. Chicares <gchicares@sbcglobal.net>

    Distinguish gcc vs. clang floating-point warnings
    
    Whereas gcc warns with '-Wfloat-conversion' here, clang warns with
    '-Wimplicit-float-conversion'.
---
 compiler_clang_warnings.make |  1 -
 ieee754_test.cpp             | 15 +++++++++++----
 2 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/compiler_clang_warnings.make b/compiler_clang_warnings.make
index 0aea81ef..4959948c 100644
--- a/compiler_clang_warnings.make
+++ b/compiler_clang_warnings.make
@@ -76,7 +76,6 @@ clang_cxx_warnings := \
   -Wno-float-equal \
   -Wno-global-constructors \
   -Wno-implicit-fallthrough \
-  -Wno-implicit-float-conversion \
   -Wno-logical-op-parentheses \
   -Wno-mismatched-tags \
   -Wno-missing-noreturn \
diff --git a/ieee754_test.cpp b/ieee754_test.cpp
index 8869e644..9e1ec344 100644
--- a/ieee754_test.cpp
+++ b/ieee754_test.cpp
@@ -45,16 +45,23 @@ int test_main(int, char*[])
     LMI_TEST(is_infinite<long double>(-infinity<long double>()));
 
     // Narrowing conversions tested here:
-#if defined __GNUC__
+#if defined LMI_GCC
 #   pragma GCC diagnostic push
 #   pragma GCC diagnostic ignored "-Wfloat-conversion"
-#endif // defined __GNUC__
+#endif // defined LMI_GCC
+#if defined LMI_CLANG
+#   pragma clang diagnostic push
+#   pragma clang diagnostic ignored "-Wimplicit-float-conversion"
+#endif // defined LMI_CLANG
     LMI_TEST(is_infinite<float      >(-infinity<double     >()));
     LMI_TEST(is_infinite<float      >(-infinity<long double>()));
     LMI_TEST(is_infinite<double     >(-infinity<long double>()));
-#if defined __GNUC__
+#if defined LMI_CLANG
+#   pragma clang diagnostic pop
+#endif // defined LMI_CLANG
+#if defined LMI_GCC
 #   pragma GCC diagnostic pop
-#endif // defined __GNUC__
+#endif // defined LMI_GCC
 
     LMI_TEST(!is_infinite(0.0));
     LMI_TEST(!is_infinite( std::numeric_limits<double>::max()));