|
From: | Aaron Hill |
Subject: | Re: updating merge request |
Date: | Fri, 20 Jan 2023 01:36:42 -0800 |
On 2023-01-19 11:01 pm, Werner LEMBERG wrote:
[SNIP] Nope. The preferred way is to make the MR's commit as pretty as possible. No final squashing.
That *almost* seems like squashing, but with more steps. Certainly, there is nothing to squash if everything is expressed neatly in one commit. At the end of the day, it makes for a nice clean history in the main line either way you approach.
The only critique might come down to where one is expected to apply their effort. When possible, engineers should take advantage of automated systems so their time is spent primarily on the problem at hand. That could mean using linters to reformat code, leveraging continuous integration to run test suites, or (in this case) letting repositories systematically squash (or rebase, or whatever) when accepting requests. It saves contributors making ambiguous choices and/or doing what amounts to busy work.
I will need to remember to keep my branches tidy before I submit anything, since I cannot rely on squash as a crutch.
-- Aaron Hill
[Prev in Thread] | Current Thread | [Next in Thread] |