Re: want to help

[Jean Abou Samra]

Le 17/01/2023 à 09:13, Lukas-Fabian Moser a écrit :
> Hi David,
>
> Am 17.01.23 um 06:18 schrieb David Zelinsky:
> > Thanks.  As I understand it I will need to first request and be granted
> > commit access.  Or is there another way, given that I am new and
> > untested?
>
> Welcome - it's great you want to contribute!
>
> What's being "tested" is mainly your merge request, and anyone can 
> create those. You'll need one of the members with commit access to 
> press the magic "merge now!" button at the end of the review process, 
> and I'm sure there'll always be one around who is happy to do so for 
> you for your first bunch of merge requests.
>
> The way I understand it, there's basically only one quality you need 
> in order to "deserve" commit access, namely the willingness _not_ to 
> press the "merge" button before a proposed patch has passed the review 
> process.
>
> But to be clear: I am not stating that you shouldn't get commit access 
> even now before your first contribution - it's just that I'm not the 
> one to decide about that.



Here is what the contributor's guide has to say on commit access:

https://lilypond.org/doc/v2.24/Documentation/contributor/commit-access

“Generally, only contributors who have already provided a number of
patches which have been merged to the main repository will be considered
for membership.”

Which is sensible, in my opinion -- especially given that having
commit access creates many ways to screw up the shared repository
with Git on the command line.

The way it has worked with newbies since I have been in the project
is that first you start contributing, and at some later point, after
a certain track record of contributions (not a whole lot, but enough
to make everyone feel confident with you), you can be given commit
access. Until then, your patches are just merged by people who do
have commit access, which is not very burdensome.

Best,
Jean

OpenPGP_signature
Description: OpenPGP digital signature