koha-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Koha-devel] template system abuse


From: Paul POULAIN
Subject: Re: [Koha-devel] template system abuse
Date: Thu, 13 Apr 2006 14:31:23 +0200
User-agent: Mozilla Thunderbird 1.0.6-7.5.20060mdk (X11/20050322)

Pierrick LE GALL a écrit :
Hi koha-devel,
We want an URL like the following: "script.pl?key1=value1&key2=value2"
> vs
href="<!-- TMPL_VAR NAME="url" -->"

at 1st glance, it sound OK to me. The only question could be : could some template designer have a reason to manage the various values separatly ? I see at least 1 case : when the template want to use a <form action> instead of a <a href> In this case, all parameters must be put as hidden input.

But i'm not sure wether this case can happends, or if it's just a brain problem (cut a hair in 4 we say in french) ...

 Couldn't we simply have
<!-- TMPL_LOOP NAME="items" -->
  <option value="<!-- TMPL_VAR NAME="value" -->" <!-- TMPL_VAR NAME="selected" -->><!-- TMPL_VAR 
NAME="name" --></option>
<!-- /TMPL_LOOP -->
With in Perl script:
selected => (condition ? ' selected="selected"' : '')

I don't see why this idea would cause problem. So, I'll adopt it unless someone show us it's a bad one !
--
Paul POULAIN et Henri Damien LAURENT
Consultants indépendants
en logiciels libres et bibliothéconomie (http://www.koha-fr.org)




reply via email to

[Prev in Thread] Current Thread [Next in Thread]