[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#67867: [PATCH shepherd] service: fix ownership+permissions on Unix s
From: |
Ludovic Courtès |
Subject: |
bug#67867: [PATCH shepherd] service: fix ownership+permissions on Unix sockets |
Date: |
Tue, 19 Dec 2023 23:38:57 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Hi Ulrich,
Ulrich Baum <ulrich.baum@ubaum.de> skribis:
> Previously, ownership and permissions of AF_UNIX sockets created by
> make-inetd-constructor and make-systemd-constructor were not set,
> leaving the socket with root:root and 755 permissions.
>
> modules/shepherd/service.scm (endpoint->listening-socket): fix chown and
> chmod calls
[...]
> (when (= AF_UNIX (sockaddr:fam address))
> - (chown sock owner group)
> - (chmod sock #o666))
> + (chown (sockaddr:path address) owner group)
> + (chmod (sockaddr:path address) #o666))
Good catch! I was surprised that fchown(2) and fchmod(2) silently did
nothing, but that’s how it is.
Pushed together with a test, which allowed me to find a related bug
(more serious, because it’s about permissions on the socket’s
directory):
9dfeb4e support: ‘mkdir-p’ sets permissions when directory already exists.
f5b7411 service: Really set ownership and permissions on Unix sockets.
(BTW, I have just renamed ‘master’ to ‘main’, but ‘master’ hasn’t been
deleted yet from the server; make sure to pick ‘main’ and adjust your
Git config.)
Thanks,
Ludo’.