[bug#67114] [PATCH 01/14] gnu: Add emacs-dnt.

[Ian Eure]

Liliana Marie Prikler <liliana.prikler@gmail.com> writes:

> Am Samstag, dem 11.11.2023 um 14:38 -0800 schrieb Ian Eure:
> > * gnu/packages/emacs-xyz.scm (emacs-dnt): New variable.
> > ---
> >  gnu/packages/emacs-xyz.scm | 25 +++++++++++++++++++++++++
> >  1 file changed, 25 insertions(+)
> >
> > diff --git a/gnu/packages/emacs-xyz.scm 
> > b/gnu/packages/emacs-xyz.scm
> > index 1319c353cb..4648432441 100644
> > --- a/gnu/packages/emacs-xyz.scm
> > +++ b/gnu/packages/emacs-xyz.scm
> > @@ -135,6 +135,7 @@
> >  ;;; Copyright © 2023 Sergiu Ivanov <sivanov@colimite.fr>
> >  ;;; Copyright © 2023 Camilo Q.S. (Distopico) 
> > <distopico@riseup.net>
> >  ;;; Copyright © 2023 Thanos Apollo <public@thanosapollo.com>
> > +;;; Copyright © 2023 Ian Eure <ian@retrospec.tv>
> >  ;;;
> >  ;;; This file is part of GNU Guix.
> >  ;;;
> > @@ -3294,6 +3295,30 @@ (define-public emacs-eww-lnum
> >  incrementally confined in Isearch manner.")
> >      (license license:gpl3+)))
> >  
> > +(define-public emacs-dnt
> > +  (let ((commit "d28d232d682094ab79cfa78c97668c6ebd327c8c")
> > +        (version "0.0.1")
> > +        (revision "1"))
> > +    (package
> > +      (name "emacs-dnt")
> > +      (version (git-version version revision commit))
> It's better to inline the base version.

Why?  As a new contributor, I’m genuinely curious.

I let-bound it because:

- In the info manual for Guix, two out of three were already.
- You’ll need to update the commit and version at the same time in 
 many cases, so having them next to each other seems convenient.
- The variable names make it more obvious if arguments to 
 git-version get swapped around.

Thanks,

 -- Ian