|
From: | Andy Tai |
Subject: | [bug#65835] [PATCH] gnu: tensorflow-lite: Update to 2.13.0 |
Date: | Thu, 14 Sep 2023 14:49:28 -0700 |
Hi,
Andy Tai <atai@atai.org> skribis:
> * gnu/packages/machine-learning.scm: (tensorflow-lite):
> Update to 2.13.0
> [inputs]: Add gemmlowp
> [native-inputs]: Remove gemmlowp-src
> * gnu/packages/patches/tensorflow-lite-disable-local-cmake-3rdparty-components.patch:
> New file
Overall LGTM. Some comments…
Could you add the patch to ‘gnu/local.mk’?
> + (patches
> + (search-patches
> + ;; patch to disable local cmake build code for 3rdparty
> + ;; componentas
> + "tensorflow-lite-disable-local-cmake-3rdparty-components.patch"))))
Please add the comment at the top of the patch itself, as reported by
‘guix lint’; also adjust indentation here as in the other files.
> + (string-append "-Dgemmlowp_ROOT=" #$(this-package-input "gemmlowp"))
> + )
Please move paren to the previous line.
> (invoke "tar" "--strip-components=1"
> "-xf" (assoc-ref inputs "fft2d-src")))
>
> - (copy-recursively (assoc-ref inputs "gemmlowp-src")
> - "/tmp/gemmlowp/")))
> + ;(copy-recursively (assoc-ref inputs "gemmlowp-src")
> + ; "/tmp/gemmlowp/")
> +
> + ))
Leftover? You can remove these two lines.
Could you send an updated patch?
Thanks in advance,
Ludo’.
[Prev in Thread] | Current Thread | [Next in Thread] |