[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#65352] Fix time-machine and network
From: |
Simon Tournier |
Subject: |
[bug#65352] Fix time-machine and network |
Date: |
Wed, 23 Aug 2023 10:32:49 +0200 |
Hi Maxim,
On Tue, 22 Aug 2023 at 22:56, Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:
>> or b)
>> (match ref
>> ((or ('commit . commit)
>> ('tag-or-commit . commit)
>> ('tag . commit))
>> (channel (inherit c)
>> (url url) (commit commit) (branch #f)))
>> (('branch . branch)
>> (channel (inherit c)
>> (url url) (commit #f) (branch branch)))
>> (#f
>> (channel (inherit c) (url url)))))
>>
>> but not ecab937897385fce3e3ce0c5f128afba4304187c. :-)
>
> I was driven by my use case where adding support for tag-or-commit was
> enough, but I think it'd be a good idea to cover all the potential ref
> types documented in update-cached-checkout, so b) makes sense to me.
Ok, b) is fine with me.
Sorry for not being clear in #64746 but this consistency was the subject
of my comment [1]. :-)
Cheers,
simon
1: https://issues.guix.gnu.org/64746#13
- [bug#64746] [PATCH 2/2] scripts: time-machine: Error when attempting to visit too old commits., (continued)
- [bug#64746] [PATCH 2/2] scripts: time-machine: Error when attempting to visit too old commits., Maxim Cournoyer, 2023/08/15
- [bug#64746] [PATCH 2/2] scripts: time-machine: Error when attempting to visit too old commits., Ludovic Courtès, 2023/08/15
- [bug#64746] [PATCH 2/2] scripts: time-machine: Error when attempting to visit too old commits., Simon Tournier, 2023/08/16
- [bug#64746] [PATCH 2/2] scripts: time-machine: Error when attempting to visit too old commits., Maxim Cournoyer, 2023/08/16
- [bug#65352] Fix time-machine and network, Simon Tournier, 2023/08/17
- [bug#65352] [PATCH 1/2] guix: git: Fix the procedure reference-available?., Simon Tournier, 2023/08/17
- [bug#65352] [PATCH 2/2] scripts: pull: Remove unused reference pair., Simon Tournier, 2023/08/17
- [bug#65352] Fix time-machine and network, Maxim Cournoyer, 2023/08/17
- [bug#65352] Fix time-machine and network, Simon Tournier, 2023/08/17
- [bug#65352] Fix time-machine and network, Maxim Cournoyer, 2023/08/22
- [bug#65352] Fix time-machine and network,
Simon Tournier <=
- [bug#65352] Fix time-machine and network, Maxim Cournoyer, 2023/08/23
- [bug#65352] Fix time-machine and network, Ludovic Courtès, 2023/08/21
- [bug#65352] Fix time-machine and network, Maxim Cournoyer, 2023/08/21
- [bug#65352] Fix time-machine and network, Ludovic Courtès, 2023/08/22
- [bug#65352] Fix time-machine and network, Maxim Cournoyer, 2023/08/22
- [bug#65352] Fix time-machine and network, Ludovic Courtès, 2023/08/21