[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#65204] [PATCH 0/6] gnu: Add go-github-com-tdewolff-hasher.
From: |
Ludovic Courtès |
Subject: |
[bug#65204] [PATCH 0/6] gnu: Add go-github-com-tdewolff-hasher. |
Date: |
Mon, 21 Aug 2023 16:03:27 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Hi,
Hilton Chain <hako@ultrarare.space> skribis:
> * gnu/packages/golang.scm (go-github-com-tdewolff-parse-v2)[#:phases]: Add
> phase 'regenerate-hash.
> [native-inputs]: Add go-github-com-tdewolff-hasher.
[...]
> + (list #:import-path "github.com/tdewolff/parse/v2"
> + #:phases
> + #~(modify-phases %standard-phases
> + (add-after 'unpack 'regenerate-hash
> + (lambda* (#:key import-path #:allow-other-keys)
> + (for-each
> + (lambda (dir)
> + (with-directory-excursion
> + (format #f "src/~a/~a" import-path dir)
> + (make-file-writable "hash.go")
> + (format #t "Generating `hash.go' for ~a...~%" dir)
> + (invoke "go" "generate")))
Maybe you can remove ‘hash.go’ in a snippet, for good measure, and add a
comment clarifying that it’s a generated file.
Otherwise the patch series LGTM!
Ludo’.
- [bug#65204] [PATCH 0/6] gnu: Add go-github-com-tdewolff-hasher., Hilton Chain, 2023/08/10
- [bug#65204] [PATCH 1/6] gnu: Add go-github-com-dgryski-go-metro., Hilton Chain, 2023/08/10
- [bug#65204] [PATCH 4/6] gnu: Add go-github-com-tdewolff-hasher., Hilton Chain, 2023/08/10
- [bug#65204] [PATCH 2/6] gnu: Add go-github-com-dgryski-go-mph., Hilton Chain, 2023/08/10
- [bug#65204] [PATCH 3/6] gnu: Add go-github-com-cespare-mph., Hilton Chain, 2023/08/10
- [bug#65204] [PATCH 5/6] gnu: go-github-com-tdewolff-parse-v2: Regenerate hash., Hilton Chain, 2023/08/10
- [bug#65204] [PATCH 0/6] gnu: Add go-github-com-tdewolff-hasher.,
Ludovic Courtès <=
- [bug#65204] [PATCH 6/6] gnu: go-github-com-tdewolff-minify-v2: Regenerate hash., Hilton Chain, 2023/08/10