[bug#63208] [PATCH v2] gnu: gstreamer: Ensure no bundle sources used

[Liliana Marie Prikler]

Am Montag, dem 01.05.2023 um 22:48 -0700 schrieb Andy Tai:
> * gnu/packages/gstreamer.scm: gstreamer: [arguments] (configure-
> flags): Add "--wrap-mode=nofallback" to ensure no subproject sources
> in repo are used
For the ChangeLog part, "Add <flag>." is typically enough.  Rationale
ought to be explained before the ChangeLog or in the code -- preferably
the latter for simple patches like the one at hand and the former if a
complex topic needs to be summarized.  
> ---
>  gnu/packages/gstreamer.scm | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm
> index 8971c11479..55876268cc 100644
> --- a/gnu/packages/gstreamer.scm
> +++ b/gnu/packages/gstreamer.scm
> @@ -474,6 +474,7 @@ (define-public gstreamer
>      (build-system meson-build-system)
>      (arguments
>       (list #:disallowed-references (list python)
> +           #:configure-flags #~(list "--wrap-mode=nofallback")
>             #:phases
>             #~(modify-phases %standard-phases
>                 #$@%common-gstreamer-phases
> 
> base-commit: 854c57c3525325070e261a2e6f81d4016ef44bfa
On the topic of wrapping dependencies: In Guix, we prefer to unbundle
them already through snippets in the source; thus, this configure-flag
would be obsolete in the ideal case.  You can of course still add it
for good measure, but I'd argue it's more important to tackle the the
actual bundle first.

Cheers