guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#55516] [PATCH v2] gnu: Add quodlibet.


From: Maxime Devos
Subject: [bug#55516] [PATCH v2] gnu: Add quodlibet.
Date: Sat, 28 May 2022 14:36:35 +0200
User-agent: Evolution 3.38.3-1

Remco van 't Veer schreef op za 28-05-2022 om 10:57 [+0200]:
> [...]
> +         (add-after 'install 'wrap-gi-typelib ; GObject Introspection
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let ((out (assoc-ref outputs "out"))
> +                   (gi-typelib-path (getenv "GI_TYPELIB_PATH")))
> +               (for-each (lambda (prog)
> +                           (wrap-program (string-append out "/bin/" prog)
> +                             `("GI_TYPELIB_PATH" ":" prefix 
> (,gi-typelib-path))))
> +                         '("exfalso" "quodlibet")))
> [...]
> +
> +    (native-inputs [...])
> +    (inputs [...])

bash-minimal (which is required when wrap-program is used for cross-
compilation reasons) is missing from inputs.  For future reference,
this issue would be detected by "guix lint".  There were some other
suboptimalities too (trailing #t, unconditional #:tests? #true), but
they have been corrected by Liliana in
<https://git.savannah.gnu.org/cgit/guix.git/commit/?id=092ec158f73b0f4a4817517149e4cb49b2d8e490>

Greetings,
Maxime.

Attachment: signature.asc
Description: This is a digitally signed message part


reply via email to

[Prev in Thread] Current Thread [Next in Thread]