[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#51838] [PATCH v5 20/45] guix: node-build-system: Add implicit libuv
From: |
Liliana Marie Prikler |
Subject: |
[bug#51838] [PATCH v5 20/45] guix: node-build-system: Add implicit libuv input. |
Date: |
Fri, 17 Dec 2021 06:08:33 +0100 |
User-agent: |
Evolution 3.42.1 |
Am Donnerstag, dem 16.12.2021 um 21:03 -0500 schrieb Philip McGrath:
> * guix/build-system/node.scm (lower): Add the version of libuv
> used as an input to the #:node package as an additional implicit
> input, so that packages needing libuv always get the correct version.
> ---
> guix/build-system/node.scm | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/guix/build-system/node.scm b/guix/build-system/node.scm
> index 330d10dca5..47af4bb9e2 100644
> --- a/guix/build-system/node.scm
> +++ b/guix/build-system/node.scm
> @@ -2,6 +2,8 @@
> ;;; Copyright © 2016 Jelle Licht <jlicht@fsfe.org>
> ;;; Copyright © 2019 Timothy Sample <samplet@ngyro.com>
> ;;; Copyright © 2021 Ludovic Courtès <ludo@gnu.org>
> +;;; Copyright © 2021 Pierre Langlois <pierre.langlois@gmx.com>
> +;;; Copyright © 2021 Philip McGrath <philip@philipmcgrath.com>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -62,10 +64,15 @@ (define private-keywords
> `(("source" ,source))
> '())
> ,@inputs
> -
> ;; Keep the standard inputs of 'gnu-build-
> system'.
> ,@(standard-packages)))
> (build-inputs `(("node" ,node)
> + ;; Many packages with native addons need
> + ;; libuv headers. The libuv version must
> + ;; be exactly the same as for the node
> + ;; package we are adding implicitly,
> + ;; so we take care of adding libuv, too.
> + ("libuv" ,@(assoc-ref (package-inputs node)
> "libuv"))
> ,@native-inputs))
> (outputs outputs)
> (build node-build)
Do this and #21 have to be separated so far from the rest? If not, I'd
do build system first, then new packages. Otherwise fair enough.
- [bug#51838] [PATCH v5 13/45] gnu: node-llparse-frontend-bootstrap: Use #:absent-dependencies., (continued)
- [bug#51838] [PATCH v5 13/45] gnu: node-llparse-frontend-bootstrap: Use #:absent-dependencies., Philip McGrath, 2021/12/16
- [bug#51838] [PATCH v5 09/45] gnu: node-ms-bootstrap: Use #:absent-dependencies., Philip McGrath, 2021/12/16
- [bug#51838] [PATCH v5 08/45] gnu: node-semver-bootstrap: Use #:absent-dependencies., Philip McGrath, 2021/12/16
- [bug#51838] [PATCH v5 14/45] gnu: node-llparse-bootstrap: Use #:absent-dependencies., Philip McGrath, 2021/12/16
- [bug#51838] [PATCH v5 15/45] gnu: node-semver: Use #:absent-dependencies., Philip McGrath, 2021/12/16
- [bug#51838] [PATCH v5 17/45] gnu: node-once: Use #:absent-dependencies., Philip McGrath, 2021/12/16
- [bug#51838] [PATCH v5 16/45] gnu: node-wrappy: Use #:absent-dependencies., Philip McGrath, 2021/12/16
- [bug#51838] [PATCH v5 21/45] guix: node-build-system: Add avoid-node-gyp-rebuild phase., Philip McGrath, 2021/12/16
- [bug#51838] [PATCH v5 19/45] gnu: node-irc: Use #:absent-dependencies., Philip McGrath, 2021/12/16
- [bug#51838] [PATCH v5 20/45] guix: node-build-system: Add implicit libuv input., Philip McGrath, 2021/12/16
- [bug#51838] [PATCH v5 20/45] guix: node-build-system: Add implicit libuv input.,
Liliana Marie Prikler <=
- [bug#51838] [PATCH v5 20/45] guix: node-build-system: Add implicit libuv input., Philip McGrath, 2021/12/18
- [bug#51838] [PATCH v5 20/45] guix: node-build-system: Add implicit libuv input., Liliana Marie Prikler, 2021/12/18
- [bug#51838] [PATCH v5 20/45] guix: node-build-system: Add implicit libuv input., Jelle Licht, 2021/12/19
- [bug#51838] [PATCH v5 20/45] guix: node-build-system: Add implicit libuv input., Philip McGrath, 2021/12/18
- [bug#51838] [PATCH v5 20/45] guix: node-build-system: Add implicit libuv input., Jelle Licht, 2021/12/19
- [bug#51838] [PATCH v5 20/45] guix: node-build-system: Add implicit libuv input., Liliana Marie Prikler, 2021/12/19
- [bug#51838] [PATCH v5 18/45] gnu: node-irc-colors: Use #:absent-dependencies., Philip McGrath, 2021/12/16
- [bug#51838] [PATCH v5 22/45] gnu: Add node-inherits., Philip McGrath, 2021/12/16
- [bug#51838] [PATCH v5 24/45] gnu: Add node-string-decoder., Philip McGrath, 2021/12/16
- [bug#51838] [PATCH v5 26/45] gnu: Add node-nan., Philip McGrath, 2021/12/16