[bug#51853] [PATCH 0/2] gnu: sendgmail: Rename package; don't limit domain.

[Ludovic Courtès]

Hi Liliana,

Liliana Marie Prikler <liliana.prikler@gmail.com> skribis:

> Am Samstag, den 20.11.2021, 00:43 -0500 schrieb Philip McGrath:
>>  (define-public sendgmail
>>    (let ((commit "e3229155a4037267ce40f1a3a681f53221aa4d8d")
>> -        (revision "0"))
>> +        (revision "1"))
> IIRC you only need to bump revision when commit changes.  When the
> recipe itself changes, e.g. due to an added patch, I'm pretty sure the
> package would be rebuilt either way.  Can you check whether you really
> need to bump it?

I think it’s fine since functionality changed a bit; and overall, I
think it’s no reason to block the patch.

Keep in mind that the goal of patch review is to help get things in
shape so we can eventually apply them (the sooner the better).  Don’t
hesitate to apply patches that are ready or ready minus details that you
can fix yourself.

Thanks for reviewing!

Ludo’.