[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#51739] [PATCH 1/3] gnu: Add realmd.
From: |
Ludovic Courtès |
Subject: |
[bug#51739] [PATCH 1/3] gnu: Add realmd. |
Date: |
Wed, 01 Dec 2021 17:42:25 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Hi,
phodina <phodina@protonmail.com> skribis:
> * gnu/packages/admin.scm (realmd): New variable.
> * gnu/packages/patches/realmd-remove-distro-detection.patch: New file.
> * gnu/local.mk: Add patch.
[...]
> + (synopsis
> + "DBus service for configuring kerberos and other online identities")
> + (description
> + "Dbus system service that manages discovery and enrollment in
> +realms/domains like Active Directory or IPA.")
Could you improve on it as per
<https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html>?
> + (home-page "https://www.freedesktop.org/software/realmd/")
> + (license license:lgpl2.1)))
Isn’t it ‘lgpl2.1+’? This is the case unless the authors explicitly
omitted the “or any later version” wording.
> +-AC_ARG_WITH([distro],
> +- [AS_HELP_STRING([--with-distro],
> +- [Configure for a specific distribution (eg:
> redhat)]
> +- )],
> +- [DISTRO=$withval],
> +- [DISTRO=])
> +-
> +-if test -z $DISTRO; then
> +- AC_CHECK_FILE(/etc/redhat-release, [DISTRO="redhat"])
> +- AC_CHECK_FILE(/etc/debian_version, [DISTRO="debian"])
> +- AC_CHECK_FILE(/etc/SuSE-release, [DISTRO="suse"])
> +-
> +- # Not customized for these yet
> +- dnl AC_CHECK_FILE(/etc/gentoo-release, [DISTRO="gentoo"])
> +- dnl AC_CHECK_FILE(/etc/slackware-version, [DISTRO="slackware"])
> +-
> +-fi
> +-
> +-if test -z $DISTRO; then
> +- AC_MSG_ERROR([Couldn't detect the distro to configure for. Specify one
> with --with-distro])
> +-fi
Rather than adding this patch, I think you can do:
#:configure-flags '("--with-distro=GNU Guix")
Could you send an updated patch?
Thanks,
Ludo’.
- [bug#51739] [PATCH 1/3] gnu: Add realmd.,
Ludovic Courtès <=