guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#51023: [PATCH] gnu: php: patch failing test case


From: Tobias Geerinckx-Rice
Subject: bug#51023: [PATCH] gnu: php: patch failing test case
Date: Tue, 05 Oct 2021 13:47:24 +0200

Ryan,

Ryan Sundberg via Guix-patches via 写道:
Fixes a failing test case in php (Zend/tests/bug74093.phpt)
See https://github.com/php/php-src/pull/7555/files for upstream status.

Thanks!  PHP is notorious for

 sleep 4 # this is how long x took to y on my laptop in 2014

but it's the bane of many test suites (and, hence, us)…

* gnu/local.mk: Include patch file php-bug-74093-test.patch
* gnu/packages/patches/php-bug-74093-test.patch: Patch file
* gnu/packages/php.scm: Add patch to php

Thanks for writing a GNU/Guix-style commit message. I made only a few tweaks, mainly adding full stops and (section)[things].

   gnu: php: Patch failing test case.

Fixes a failing test case in PHP (Zend/tests/bug74093.phpt). See <https://github.com/php/php-src/pull/7555/files> for upstream status.

   * gnu/packages/php.scm (php)[source]: Add patch.
   * gnu/packages/patches/php-bug-74093-test.patch: New file.
   * gnu/local.mk (dist_patch_DATA): Add it.

The * line order is just what I'm used to writing, nothing more.

Pushed as 9aaf402a379b9ac9e4c3eee5b16f7496d7606e91!

Kind regards,

T G-R

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]