[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#46044] [PATCH] Improvements to handling po files
From: |
Ludovic Courtès |
Subject: |
[bug#46044] [PATCH] Improvements to handling po files |
Date: |
Thu, 28 Jan 2021 15:58:19 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Hi!
Julien Lepiller <julien@lepiller.eu> skribis:
> here are two patches to improve our handling of po files. Yesterday I
> pushed again new po files that were broken, and I didn't notice. The
> first patch ensure po files are normalized. The TP automatically
> normalized po, but weblate doesn't, using the indent method instead.
> This creates huge patches like yesterday. Instead, normalizing ensures
> we only see relevant changes.
Makes sense.
> The second patch adds a check-po target to the Makefile that runs
> msgfmt on every po file we have, to make sure they are at least
> correct. That's not enough for manual translations, but that can be
> spotted easily when running "make". This would have spotted the issues
> I introduced yesterday.
Yes, or running “make as-derivation” (sometimes just “make” isn’t enough
to catch issues it seems, not sure why.)
>>From 42aa42512dba281f3d33e7883c922c0f5704bee4 Mon Sep 17 00:00:00 2001
> From: Julien Lepiller <julien@lepiller.eu>
> Date: Fri, 22 Jan 2021 21:28:28 +0100
> Subject: [PATCH 1/2] Makefile.am: Normalize downloaded po files.
>
> * Makefile.am (make-download-po-rule): Normalize po files.
OK!
>>From 8be36b2d651be108bc1e7fe7790f889dd19c679d Mon Sep 17 00:00:00 2001
> From: Julien Lepiller <julien@lepiller.eu>
> Date: Fri, 22 Jan 2021 21:24:23 +0100
> Subject: [PATCH 2/2] Makefile.am: Add check-po rule.
>
> * Makefile.am (make-check-po-rule): New definition.
> Add top-level 'eval' and calls to 'make-check-po-rule' to generate
> 'check-po.DOMAIN' rules.
> (check-po): New rule.
[...]
> +# make-check-po-rule DOMAIN DIRECTORY [FILE-NAME-PREFIX]
> +define make-check-po-rule
Could you add a line or two above the definition explaining what it
does?
> +check-po.$(1):
> + if [ -f "$(top_srcdir)/$(2)/LINGUAS" ]; then
> \
> + LINGUAS="`grep -v '^[[:blank:]]*#' < $(top_srcdir)/$(2)/LINGUAS`" ;
> \
> + else
> \
> + LINGUAS="`(cd $(top_srcdir)/$(2);
> \
> + for i in *.po; do echo $$$$i; done) | cut -d . -f 2`" ;
> \
> + fi ;
> \
> + for lang in $$$$LINGUAS; do
> \
> + if [ -f "$(top_srcdir)/$(2)/$(3)$$$$lang.po" ]; \
> + then
> \
> + if ! msgfmt -c "$(top_srcdir)/$(2)/$(3)$$$$lang.po" ; \
> + then \
> + exit 1 ; \
> + fi ; \
> + fi ;
> \
Would be great if you could align backslashes. :-)
Otherwise LGTM, thanks!
Ludo’.