[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#45721] Telegram Desktop (v13)
From: |
Leo Prikler |
Subject: |
[bug#45721] Telegram Desktop (v13) |
Date: |
Sun, 17 Jan 2021 13:13:07 +0100 |
User-agent: |
Evolution 3.34.2 |
Hi,
Am Samstag, den 16.01.2021, 20:52 -0500 schrieb Raghav Gururajan:
> * gnu/packages/fcitx.scm (fcitx-qt5): New variable.
LGTM.
> + (version
> + (git-version "1" revision commit))
You can still use "0" or "0.0.0" for the base version.
> + (add-after 'unpack 'delete-thirdparty
> + (lambda _
> + (with-directory-excursion "src/third_party"
> + (for-each delete-file-recursively
> + ;; [1] Keep Abseil-CPP, LibSRTP, LibVPx,
> LibYuv,
> + ;; OpenH264, PFFFT, RnNoise and UsrSCTP.
> + ;; [2] Tg_owt uses custom fork of Abseil-
> CPP,
> + ;; LibSRTP, OpenH264 and RnNoise.
> + ;; [3] Tg_owt uses specific
> version/commit of LibVPx,
> + ;; which is different from one available
> in Guix.
> + ;; [4] LibYuv, PFFFT and UsrSCTP aren't
> available.
> + (list
> + "yasm")))
I forgot to mention this, but this should be a snippet, perhaps even a
computed origin.
Also, as it has been noted in your Nextcloud patch (IIRC), you should
formulate this in terms of what to keep.
E.g.
'(;; custom forks of existing packages
;; the forks are incompatible with what we have in Guix
"abseil-cpp" "libsrtp" "openh264" "rnnoise"
;; XXX: packages currently lacking a description
"pffft" "usrsctp")
> + (add-after 'delete-thirdparty 'copy-inputs
> + (lambda* (#:key inputs outputs #:allow-other-keys)
> + (let* ((libvpx-from (assoc-ref inputs "libvpx"))
> + (libyuv-from (assoc-ref inputs "libyuv"))
> + (libvpx-to (string-append (getcwd)
> + "/src/third_party/li
> bvpx/source/libvpx"))
> + (libyuv-to (string-append (getcwd)
> + "/src/third_party/li
> byuv")))
> + (copy-recursively libvpx-from libvpx-to)
> + (copy-recursively libyuv-from libyuv-to))
> + #t)))))
Should be after unpack (see above), otherwise LGTM.
> + ("libvpx"
> + ,(origin
> + (method git-fetch)
> + (uri
> + (git-reference
> + (url "https://chromium.googlesource.com/webm/libvpx")
> + (commit "5b63f0f")))
> + (file-name
> + (git-file-name "libvpx" version))
> + (sha256
> + (base32
> "1psvxaddihlw1k5n0anxif3qli6zyw2sa2ywn6mkb8six9myrp68"))))
> + ("libyuv"
> + ,(origin
> + (method git-fetch)
> + (uri
> + (git-reference
> + (url "https://chromium.googlesource.com/libyuv/libyuv
> ")
> + (commit "ad89006")))
> + (file-name
> + (git-file-name "libyuv" version))
> + (sha256
> + (base32
> "01knnk4h247rq536097n9n3s3brxlbby3nv3ppdgsqfda3k159ll"))))
Use long hashes. Also, try to make things work with the nearest
release. You might also want to package them individually as "libvpx-
for-telegram-desktop" etc. if everything else fails, see stepmania as
an example with a custom ffmpeg.
As per our discussion in IRC, this should be part of the telegram
module.
Regards,
Leo
- [bug#45721] Telegram Desktop (v9), (continued)
- [bug#45721] Telegram Desktop (v10), Raghav Gururajan, 2021/01/16
- [bug#45721] Telegram Desktop (v11), Raghav Gururajan, 2021/01/16
- [bug#45721] Telegram Desktop (v12), Raghav Gururajan, 2021/01/16
- [bug#45721] Telegram Desktop (v13), Raghav Gururajan, 2021/01/16
- [bug#45721] Telegram Desktop (v13),
Leo Prikler <=
[bug#45721] Telegram Desktop (v14), Raghav Gururajan, 2021/01/17
[bug#45721] Telegram Desktop (v17), Raghav Gururajan, 2021/01/20
[bug#45721] Telegram Desktop (v18), Raghav Gururajan, 2021/01/20
[bug#45721] Telegram Desktop (v19), Raghav Gururajan, 2021/01/20