[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#45409] [PATCH v3 2/3] guix: Move narinfo code from substitute scrip
From: |
Ludovic Courtès |
Subject: |
[bug#45409] [PATCH v3 2/3] guix: Move narinfo code from substitute script to module. |
Date: |
Tue, 05 Jan 2021 22:58:32 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Christopher Baines <mail@cbaines.net> skribis:
> This separation between the code for dealing with narinfos from the code doing
> that for a purpose should make things clearer, and better support components
> other that the substitute script in using this code.
>
> This is just moving the code around, no code should have been significantly
> changed.
>
> * guix/scripts/substitute.scm (<narinfo>): Move record type to (guix narinfo).
> (fields->alist, narinfo-hash-algorithm+value, narinfo-hash->sha256,
> narinfo-signature->canonical-sexp, narinfo-maker, read-narinfo,
> narinfo-sha256, valid-narinfo?, write-narinfo, narinfo->string,
> string->narinfo, equivalent-narinfo?, supported-compression?,
> compresses-better?, narinfo-best-uri): Move procedures to (guix narinfo).
> (%compression-methods): Move variable to (guix narinfo).
> * guix/narinfo.scm: New file.
> * Makefile.am (MODULES): Add it.
> * po/guix/POTFILES.in: Add 'guix/narinfo.scm'.
[...]
> +(define-module (guix narinfo)
[...]
> + #:use-module (guix scripts substitute)
This one should be removed.
Otherwise LGTM!
Thanks,
Ludo’.
[bug#45409] [PATCH v3 2/3] guix: Move narinfo code from substitute script to module., Christopher Baines, 2021/01/04
- [bug#45409] [PATCH v3 2/3] guix: Move narinfo code from substitute script to module.,
Ludovic Courtès <=
[bug#45409] [PATCH v3 1/3] substitute: Untangle skipping authentication from valid-narinfo?., Ludovic Courtès, 2021/01/05