grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v13 1/9] PE: Add LoongArch definitions


From: Daniel Kiper
Subject: Re: [PATCH v13 1/9] PE: Add LoongArch definitions
Date: Wed, 5 Apr 2023 18:52:57 +0200
User-agent: NeoMutt/20170113 (1.7.2)

On Fri, Mar 31, 2023 at 02:01:10PM +0800, Xiaotian Wu wrote:

Missing commit message. Almost every patch has to have commit message
which describes what it does, why and how (proportions of these things
may vary from patch to patch). Proper subject is usually not enough.
Please fix this here and in subsequent patches...

> Signed-off-by: Xiaotian Wu <wuxiaotian@loongson.cn>
> Signed-off-by: Zhou Yang <zhouyang@loongson.cn>

I expect Zhou first worked on the patch and than Xiaotian taken over the
work. If this is true then SOB should be sorted in the following way:

  Signed-off-by: Zhou Yang <zhouyang@loongson.cn>
  Signed-off-by: Xiaotian Wu <wuxiaotian@loongson.cn>

Usually sender is at the end of the list...

Daniel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]