Re: [PATCH v2 00/15] GDB script fixes and improvements

[Daniel Kiper]

Hi Glenn,

On Fri, May 13, 2022 at 06:12:33PM -0500, Glenn Washburn wrote:
> There's been a lot of changes since v1. There are more fixes and more
> features. The majority of the shell code has been moved to an external
> file named gdb_helper.sh, instead of being inline in the GDB script. The
> one (direct) PERL dependency in GRUB has been removed and converted to
> shell script. Also a section on debugging is added to the developer docs.
>
> Glenn
>
> Glenn Washburn (15):
>   gdb: Fix redirection issue in dump_module_sections
>   gdb: Prevent wrapping when writing to .segments.tmp
>   gdb: If no modules have been loaded, do not try to load module symbols
>   gdb: Move runtime module loading into runtime_load_module
>   gdb: Get correct mod variable value
>   gdb: Do not run load_module if module has already been loaded
>   gdb: Add functions to make loading from dynamically positioned targets
>     easier
>   gdb: Remove Perl dependency for GRUB GDB script
>   gdb: If enabled, print line used to load EFI kernel symbols when using
>     gdb_grub script
>   gdb: Conditionally run GDB script logic for dynamically or statically
>     positioned GRUB
>   gdb: Only connect to remote target once when first sourced
>   gdb: Allow user defined "onload_<modname>" command to be run when
>     module is loaded
>   gdb: Allow running user-defined commands at GRUB start
>   gdb: Add ability to turn on shell tracing for gdb helper script
>   docs: Add debugging chapter to development documentation
>
>  config.h.in                 |   3 +
>  docs/grub-dev.texi          | 191 ++++++++++++++++++++++++++++++++++
>  grub-core/Makefile.core.def |   4 +-
>  grub-core/gdb_grub.in       | 198 ++++++++++++++++++++++++++++++++----
>  grub-core/gdb_helper.sh.in  | 108 ++++++++++++++++++++
>  grub-core/gmodule.pl.in     |  30 ------
>  grub-core/kern/efi/efi.c    |   4 +-
>  grub-core/kern/efi/init.c   |  19 +++-
>  include/grub/efi/efi.h      |   2 +-
>  9 files changed, 501 insertions(+), 58 deletions(-)
>  create mode 100644 grub-core/gdb_helper.sh.in
>  delete mode 100644 grub-core/gmodule.pl.in

This is great improvement. However, after looking at the list of changed
files it seems to me it should be rebased. May I ask you to do that?
Sorry for the inconvenience.

Daniel