[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] fix for groff Git regression (Savannah #64005)
From: |
Ralph Corderoy |
Subject: |
[PATCH] fix for groff Git regression (Savannah #64005) |
Date: |
Thu, 06 Apr 2023 12:59:57 +0100 |
Hi Branden,
> Feedback welcome.
...
> +input='.pl 18v
> +.LP
> +The first page is \n%.
> +.DS
> +display
> +.DE
> +.bp
> +.LP
> +The second page is \n%.
> +.pl \n(nlu'
> +
> +output=$(printf '%s\n' "$input" | "$groff" -Tascii -P-cbou -ms)
> +echo "$output"
> +echo "$output" | grep -Fqx 'The second page is 2.'
Would it be worth testing all of $output is exactly as expected?
This would widen what's being tested which may catch a future regression
outside the scope of this test, e.g. with .DS/.DE.
The downside is a deliberate change might ripple through more tests but
the fix-up should be straightforward and would preserve the wider
testing.
$output can be encoded if it's considered too long. These two are
equivalent:
output='
The first page is 1.
display
-2-
The second page is 2.'
output=\
',,,,,,The first page is 1.,, display,,,,,,,,,
,,, -2-,,,The second page is 2.
'
output=$(echo "$output" | tr , \\012)
--
Cheers, Ralph.
- Re: pdfroff in groff 1.23.0.rc3 changes compared to 1.22.4, (continued)
- Re: pdfroff in groff 1.23.0.rc3 changes compared to 1.22.4, Michał Kruszewski, 2023/04/04
- Re: pdfroff in groff 1.23.0.rc3 changes compared to 1.22.4, G. Branden Robinson, 2023/04/04
- Re: pdfroff in groff 1.23.0.rc3 changes compared to 1.22.4, Michał Kruszewski, 2023/04/05
- Re: pdfroff in groff 1.23.0.rc3 changes compared to 1.22.4, G. Branden Robinson, 2023/04/05
- Re: pdfroff in groff 1.23.0.rc3 changes compared to 1.22.4, Michał Kruszewski, 2023/04/05
- Re: pdfroff in groff 1.23.0.rc3 changes compared to 1.22.4, G. Branden Robinson, 2023/04/05
- Re: pdfroff in groff 1.23.0.rc3 changes compared to 1.22.4, Michał Kruszewski, 2023/04/05
- Re: pdfroff in groff 1.23.0.rc3 changes compared to 1.22.4, Dave Kemper, 2023/04/05
- Re: pdfroff in groff 1.23.0.rc3 changes compared to 1.22.4, G. Branden Robinson, 2023/04/05
- [PATCH] fix for groff Git regression (Savannah #64005), G. Branden Robinson, 2023/04/05
- [PATCH] fix for groff Git regression (Savannah #64005),
Ralph Corderoy <=
- sensitivity vs. specificity in software testing (was: [PATCH] fix for groff Git regression (Savannah #64005)), G. Branden Robinson, 2023/04/06
- sensitivity vs. specificity in software testing, Ralph Corderoy, 2023/04/07
- Re: sensitivity vs. specificity in software testing, G. Branden Robinson, 2023/04/07
- Re: sensitivity vs. specificity in software testing, Ralph Corderoy, 2023/04/08
- Re: sensitivity vs. specificity in software testing, G. Branden Robinson, 2023/04/09
- Re: pdfroff in groff 1.23.0.rc3 changes compared to 1.22.4, Peter Schaffter, 2023/04/05
- Re: pdfroff in groff 1.23.0.rc3 changes compared to 1.22.4, Michał Kruszewski, 2023/04/05
- an opinionated history of *roff macro packages (was: pdfroff in groff 1.23.0.rc3 changes compared to 1.22.4), G. Branden Robinson, 2023/04/06
- Re: an opinionated history of *roff macro packages (was: pdfroff in groff 1.23.0.rc3 changes compared to 1.22.4), Damian McGuckin, 2023/04/06
- memorandum macros (mm) in 1976/77 (was: an opinionated history of *roff macro packages), G. Branden Robinson, 2023/04/06