[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[groff] 03/04: [tbl]: Drop ill-premised test.
From: |
G. Branden Robinson |
Subject: |
[groff] 03/04: [tbl]: Drop ill-premised test. |
Date: |
Sat, 4 Feb 2023 15:21:10 -0500 (EST) |
gbranden pushed a commit to branch master
in repository groff.
commit 3777d44e1ad8fe03e432a0e931b3725569479143
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
AuthorDate: Sat Feb 4 01:40:12 2023 -0600
[tbl]: Drop ill-premised test.
[tbl]: Drop XFAIL test. It was written with an unclear understanding of
how DWB (AT&T) and Heirloom Doctools troff behaved. The individual
checks might come back, modified.
* src/preproc/tbl/tests/table-lacks-spurious-top-border.sh: Delete.
* src/preproc/tbl/tbl.am (tbl_TESTS): Drop it.
(tbl_XFAIL_TESTS, XFAIL_TESTS): Drop now empty assignment and
unnecessary update, respectively.
---
ChangeLog | 13 +++++
src/preproc/tbl/tbl.am | 5 --
.../tbl/tests/table-lacks-spurious-top-border.sh | 55 ----------------------
3 files changed, 13 insertions(+), 60 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 9b7d0a2f4..dcae4906d 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,16 @@
+2023-02-04 G. Branden Robinson <g.branden.robinson@gmail.com>
+
+ [tbl]: Drop XFAIL test. It was written with an unclear
+ understanding of how DWB (AT&T) and Heirloom Doctools troff
+ behaved. The individual checks might come back, modified.
+
+ * src/preproc/tbl/tests/table-lacks-spurious-top-border.sh:
+ Delete.
+
+ * src/preproc/tbl/tbl.am (tbl_TESTS): Drop it.
+ (tbl_XFAIL_TESTS, XFAIL_TESTS): Drop now empty assignment and
+ unnecessary update, respectively.
+
2023-02-04 Bertrand Garrigues <bertrand.garrigues@laposte.net>
Update gnulib submodule
diff --git a/src/preproc/tbl/tbl.am b/src/preproc/tbl/tbl.am
index 1996e302b..d4b0edb57 100644
--- a/src/preproc/tbl/tbl.am
+++ b/src/preproc/tbl/tbl.am
@@ -41,16 +41,11 @@ tbl_TESTS = \
src/preproc/tbl/tests/save-and-restore-inter-sentence-space.sh \
src/preproc/tbl/tests/save-and-restore-line-numbering.sh \
src/preproc/tbl/tests/save-and-restore-tab-stops.sh \
- src/preproc/tbl/tests/table-lacks-spurious-top-border.sh \
src/preproc/tbl/tests/warn-on-long-boxed-unkept-table.sh \
src/preproc/tbl/tests/x-column-modifier-works.sh
TESTS += $(tbl_TESTS)
EXTRA_DIST += $(tbl_TESTS)
-tbl_XFAIL_TESTS = \
- src/preproc/tbl/tests/table-lacks-spurious-top-border.sh
-XFAIL_TESTS += $(tbl_XFAIL_TESTS)
-
# Local Variables:
# fill-column: 72
diff --git a/src/preproc/tbl/tests/table-lacks-spurious-top-border.sh
b/src/preproc/tbl/tests/table-lacks-spurious-top-border.sh
deleted file mode 100755
index 5a0a82945..000000000
--- a/src/preproc/tbl/tests/table-lacks-spurious-top-border.sh
+++ /dev/null
@@ -1,55 +0,0 @@
-#!/bin/sh
-#
-# Copyright (C) 2022 Free Software Foundation, Inc.
-#
-# This file is part of groff.
-#
-# groff is free software; you can redistribute it and/or modify it under
-# the terms of the GNU General Public License as published by the Free
-# Software Foundation, either version 3 of the License, or
-# (at your option) any later version.
-#
-# groff is distributed in the hope that it will be useful, but WITHOUT
-# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
-# FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
-# for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with this program. If not, see <http://www.gnu.org/licenses/>.
-#
-
-groff="${abs_top_builddir:-.}/test-groff"
-fail=
-
-wail () {
- echo "...FAILED" >&2
- echo "$output"
- fail=yes
-}
-
-# GNU tbl draws vertical lines 1v taller than they need to be on nroff
-# devices to enable them to cross a potential horizontal line in the
-# table. This can lead to a spurious top border.
-
-input='.ll 12n
-.TS
-| L |.
-_
-1234567890
-.TE
-.pl \n(nlu
-'
-
-echo "checking height of table with plain vertical rules" >&2
-output=$(printf "%s" "$input" | "$groff" -Tascii -t)
-lines=$(echo "$output" | wc -l)
-test $lines -eq 1 || wail
-
-echo "checking content of table with plain vertical rules" >&2
-output=$(printf "%s" "$input" | "$groff" -Tascii -t)
-# If we fix the horizontal width issue (Savannah #62471), take out " ?".
-echo "$output" | sed -n '1p' | grep -Eqx -- '\|1234567890 ?\|' || wail
-
-test -z "$fail"
-
-# vim:set ai et sw=4 ts=4 tw=72:
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [groff] 03/04: [tbl]: Drop ill-premised test.,
G. Branden Robinson <=