groff-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[groff] 19/28: m4/groff.m4: Fix computational grammar error.


From: G. Branden Robinson
Subject: [groff] 19/28: m4/groff.m4: Fix computational grammar error.
Date: Wed, 25 May 2022 22:43:23 -0400 (EDT)

gbranden pushed a commit to branch master
in repository groff.

commit e59d83aeb897d430f8b8fe21fe40346f63c83372
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
AuthorDate: Tue May 24 19:10:13 2022 -0500

    m4/groff.m4: Fix computational grammar error.
    
    * m4/groff.m4 (GROFF_CHECK_GROHTML_PROGRAMS): Fix logic error in
      computation of verb to be used in notice message.
    
    Also fix code style nit: drop unnecessary quotation when setting shell
    variable to empty value.
---
 ChangeLog   |  5 +++++
 m4/groff.m4 | 15 ++++++++-------
 2 files changed, 13 insertions(+), 7 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index cc882e4d..b4388d18 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2022-05-24  G. Branden Robinson <g.branden.robinson@gmail.com>
+
+       * m4/groff.m4 (GROFF_CHECK_GROHTML_PROGRAMS): Fix logic error in
+       computation of verb to be used in notice message.
+
 2022-05-24  G. Branden Robinson <g.branden.robinson@gmail.com>
 
        * m4/groff.m4 (GROFF_PROG_YACC, GROFF_URW_FONTS_CHECK,
diff --git a/m4/groff.m4 b/m4/groff.m4
index 36b2078a..f51a11c8 100644
--- a/m4/groff.m4
+++ b/m4/groff.m4
@@ -189,7 +189,7 @@ AC_DEFUN([GROFF_CHECK_GROHTML_PROGRAMS], [
     plural=`set $missing; test $[#] -gt 1 && echo s`
     oxford=`set $missing; test $[#] -gt 2 && echo ,`
     missing=`set $missing
-      missing=""
+      missing=
       while test $[#] -gt 0
       do
         case $[#] in
@@ -200,12 +200,13 @@ AC_DEFUN([GROFF_CHECK_GROHTML_PROGRAMS], [
         shift
       done
       echo $missing`
-    if test $[#] -gt 1
-    then
-      verb=were
-    else
-      verb=was
-    fi
+    verb=`set $missing
+      if test $[#] -gt 1
+      then
+        echo were
+      else
+        echo was
+      fi`
 
     grohtml_notice="The program$plural $missing $verb not found in \
 \$PATH.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]