Re: [PATCH] Fix DEVEL=1 build

[Yuchen Pei]

Hi Mark
On Thu 2023-10-05 01:09:24 -0400, Mark H Weaver wrote:

> Hi Yuchen,

> Yuchen Pei <id@ypei.org> writes:

>> When setting DEVEL=1 in makeicecat, the build fails at the following
>> step

>>     for file_to_append in $(cd "${DATADIR}"/files-to-append; find . -type f 
>> -print); do
>>         echo Appending new data to the end of file: $file_to_append
>>         cat "${DATADIR}"/files-to-append/$file_to_append >> $file_to_append
>>     done

> Thanks for reporting this.  I haven't seen this behavior.

That's surprising to me, because I'm not the first one doing this. In
fact, I learned the trick from the AUR PKGBUILD:

https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=icecat#n54

--8<---------------cut here---------------start------------->8---
    sed -e 's/DEVEL=0/DEVEL=1/g' -i makeicecat
    # Also you can choose your locale using external variable _LOCALE. By 
default in upstream script this locale is es-ES
    [ -z "$_LOCALE" ] || sed -e "s/es-ES/$_LOCALE/g" -i makeicecat && echo 
"$_LOCALE" > custom-shipped-locales
    rm -rf data/files-to-append/l10n/*
--8<---------------cut here---------------end--------------->8---

Are you able to reprod a failure when doing the following in a clean git
clone / worktree?

sed -e 's/DEVEL=0/DEVEL=1/g' -i makeicecat
./makeicecat

>> Removing ${DATADIR}/files-to-append/l10n/* fixes the issue.

> I would prefer to find a better solution.  Those files are there for a
> reason.  We should not simply delete them.

They are probably useful when DEVEL=0, but I'm not sure about when
DEVEL=1.

> In order to fix this properly, we must first understand what went wrong.
> Was there an error message?  Can you provide a transcript of the session
> demonstrating the failure?

Sorry I don't have enough disk space atm, or time to clean my disk...
I'll try when I have time for these tasks. But IIRC it is pretty simple:
some non-existing directory component in $file_to_append

for example, we have
data/files-to-append/l10n/it/browser/browser/preferences/preferences.ftl

which in the cat command expands to

cat data/files-to-append/l10n/it/browser/browser/preferences/preferences.ftl >> 
l10n/it/browser/browser/preferences/preferences.ftl

at least part of the l10n/it/browser/browser/preferences/ does not exist
yet when this cat command is attempted.

> [... 3 lines elided]


Best,
Yuchen

--
Timezone: UTC+11
PGP Key: 47F9 D050 1E11 8879 9040  4941 2126 7E93 EF86 DFD0
          <https://ypei.org/assets/ypei-pubkey.txt>