[gnunet] 16/18: TNG: Fixed misplaced increase of queue length.

[gnunet]

This is an automated email from the git hooks/post-receive script.

t3sserakt pushed a commit to branch master
in repository gnunet.

commit 498b0c3957b499213246972d95b5c98d8553b2d9
Author: t3sserakt <t3ss@posteo.de>
AuthorDate: Thu Apr 27 18:13:55 2023 +0200

    TNG: Fixed misplaced increase of queue length.
---
 src/transport/gnunet-service-tng.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/src/transport/gnunet-service-tng.c 
b/src/transport/gnunet-service-tng.c
index f030944bb..5aa9f1a51 100644
--- a/src/transport/gnunet-service-tng.c
+++ b/src/transport/gnunet-service-tng.c
@@ -4488,15 +4488,19 @@ queue_send_msg (struct Queue *queue,
     }
     GNUNET_CONTAINER_DLL_insert (queue->queue_head, queue->queue_tail, qe);
     GNUNET_assert (CT_COMMUNICATOR == queue->tc->type);
-    queue->queue_length++;
-    queue->tc->details.communicator.total_queue_length++;
-    //FIXME Probably this if statement here is completely wrong in this method,
-    // and only fixed a symptom, but not an actual bug.
     if (0 == queue->q_capacity)
     {
+      // Messages without FC or fragments can get here.
+      if (NULL != pm)
+        GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                    "Message %llu (pm type %u) was not send because queue has 
no capacity.\n",
+                    pm->logging_uuid,
+                    pm->pmt);
       GNUNET_free (env);
       return;
     }
+    queue->queue_length++;
+    queue->tc->details.communicator.total_queue_length++;
     if (GNUNET_NO == queue->unlimited_length)
       queue->q_capacity--;
     GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,

-- 
To stop receiving notification emails like this one, please contact
gnunet@gnunet.org.