[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[taler-exchange] branch master updated: -add FIXMEs
From: |
gnunet |
Subject: |
[taler-exchange] branch master updated: -add FIXMEs |
Date: |
Sun, 05 Dec 2021 19:23:18 +0100 |
This is an automated email from the git hooks/post-receive script.
grothoff pushed a commit to branch master
in repository exchange.
The following commit(s) were added to refs/heads/master by this push:
new 6ba9f934 -add FIXMEs
6ba9f934 is described below
commit 6ba9f934c42298cc2f21e2320a13a9a752cba9ab
Author: Christian Grothoff <christian@grothoff.org>
AuthorDate: Sun Dec 5 19:23:16 2021 +0100
-add FIXMEs
---
src/exchangedb/exchange-0001.sql | 2 ++
src/lib/exchange_api_common.c | 8 +++++---
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/src/exchangedb/exchange-0001.sql b/src/exchangedb/exchange-0001.sql
index 80ad9527..c5f5153a 100644
--- a/src/exchangedb/exchange-0001.sql
+++ b/src/exchangedb/exchange-0001.sql
@@ -525,6 +525,7 @@ CREATE TABLE IF NOT EXISTS recoup
,timestamp INT8 NOT NULL
,reserve_out_serial_id INT8 NOT NULL REFERENCES reserves_out
(reserve_out_serial_id) ON DELETE CASCADE
);
+-- FIXME: explain table better!
COMMENT ON TABLE recoup
IS 'Information about recoups that were executed';
COMMENT ON COLUMN recoup.known_coin_id
@@ -552,6 +553,7 @@ CREATE TABLE IF NOT EXISTS recoup_refresh
,timestamp INT8 NOT NULL
,rrc_serial INT8 NOT NULL UNIQUE REFERENCES refresh_revealed_coins
(rrc_serial) ON DELETE CASCADE
);
+-- FIXME: explain table better!
COMMENT ON COLUMN recoup_refresh.known_coin_id
IS 'Do not CASCADE ON DROP on the known_coin_id, as we may keep the coin
alive!';
COMMENT ON COLUMN recoup_refresh.rrc_serial
diff --git a/src/lib/exchange_api_common.c b/src/lib/exchange_api_common.c
index 38c4ce1a..c5cf4110 100644
--- a/src/lib/exchange_api_common.c
+++ b/src/lib/exchange_api_common.c
@@ -831,7 +831,8 @@ TALER_EXCHANGE_verify_coin_history (
return GNUNET_SYSERR;
}
*h_denom_pub = rr.h_denom_pub;
- add = GNUNET_YES;
+ add = GNUNET_YES; // FIXME: one of these should be a "NO"
+ // => need better tests!!!
}
else if (0 == strcasecmp (type,
"OLD-COIN-RECOUP"))
@@ -878,7 +879,7 @@ TALER_EXCHANGE_verify_coin_history (
GNUNET_break_op (0);
return GNUNET_SYSERR;
}
- add = GNUNET_YES;
+ add = GNUNET_YES; // FIXME: one of these should be a "NO"
}
else
{
@@ -911,7 +912,8 @@ TALER_EXCHANGE_verify_coin_history (
However, for the implementation, we first *add* up all of
these negative amounts, as we might get refunds before
deposits from a semi-evil exchange. Then, at the end, we do
- the subtraction by calculating "total = total - rtotal"
*/GNUNET_assert (GNUNET_NO == add);
+ the subtraction by calculating "total = total - rtotal" */
+ GNUNET_assert (GNUNET_NO == add);
if (0 >
TALER_amount_add (&rtotal,
&rtotal,
--
To stop receiving notification emails like this one, please contact
gnunet@gnunet.org.
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [taler-exchange] branch master updated: -add FIXMEs,
gnunet <=