[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[task #16222] Arithmetic operators to convert areas for example mag/arcs
From: |
Mohammad Akhlaghi |
Subject: |
[task #16222] Arithmetic operators to convert areas for example mag/arcsec2 to counts/pix |
Date: |
Mon, 24 Apr 2023 15:59:11 -0400 (EDT) |
Follow-up Comment #7, task #16222 (project gnuastro):
Thanks a lot Bharat, the commit looks good.
There is just one thing that worries me: the 'gal_wcs_pixel_scale' function
which is called on every conversion. This function is computationally much
more complex than the actual unit conversion. So if someone wants to convert
thousands of values, 'gal_wcs_pixel_scale' will be called thousands of times.
A more robust way is to estimate the pixel scale once (before
'arithmetic_function_binary_flt' starts to parse the set of inputs), and pass
the pixel scale to 'gal_units_arcsecsq_to_pixnum' instead of the WCS ;-).
By the way, can you also implement the inverse operation?
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/task/?16222>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [task #16222] Arithmetic operators to convert areas for example mag/arcsec2 to counts/pix,
Mohammad Akhlaghi <=