[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [patch] nk6510.c: Advance progress indicator in place
From: |
Yoni Rabkin |
Subject: |
Re: [patch] nk6510.c: Advance progress indicator in place |
Date: |
Sat, 22 Mar 2008 11:27:30 +0200 |
User-agent: |
Gnus/5.110007 (No Gnus v0.7) Emacs/23.0.50 (gnu/linux) |
"Pawel Kot" <address@hidden> writes:
> Hi,
>
> On Fri, Mar 21, 2008 at 2:31 PM, Yoni Rabkin <address@hidden> wrote:
>> "Pawel Kot" <address@hidden> writes:
>> > On Fri, Mar 21, 2008 at 2:18 PM, Yoni Rabkin <address@hidden> wrote:
>> >> I've attached two patches which do the same thing in a different way,
>> >> both against today's CVS.
>> >
>> > Please remember that correct way to do this is to provide callback
>> > function here. It is in fact temporary solution that libgnokii prints
>> > something to stdout or stderr.
>>
>> This was actually my first thought when I looked at the code. But you
>> know what they say about "temporary solutions"...
>
> :)
>
>> Does this all have anything to do with the fact that you have adding
>> GNU/Readline in the TODO? Do you ultimately want it to handle all the
>> output?
>
> No. Readline in TODO is to handle input :)
> Solution here should be able to support all GUI apps as well.
> Currently it doesn't. Howevery the code to support callback function
> and moving printing code to gnokii is fairly trivial.
Want me to start working on that, or does someone else have that
covered?
--
"Cut your own wood and it will warm you twice"