Re: [gcmd-dev] Migration away from GnomeVFS is done

[Uwe Scholz]

Hi Stefan,

thanks for your message. This looks interesting!

Am Fri, 15 Oct 2021 22:30:20 +0200 schrieb Stefan Czinczoll:
>
> Unfortunately after updating Ubuntu 20.04 with GCC compiler version 11 I 
> the makefile was written okay, but compiling fails:
> 
> make[3]: Verzeichnis 
> „/home/stefan/Downloads/gnome-commander-master/src/dialogs“ wird betreten
> g++ -DHAVE_CONFIG_H -I. -I../..  -I../.. -I./.. -pthread 
> -I/usr/include/gtk-2.0 -I/usr/lib/x86_64-linux-gnu/gtk-2.0/include 
> -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 
> -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libmount 
> -I/usr/include/blkid -I/usr/include/pango-1.0 -I/usr/include/fribidi 
> -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/harfbuzz 
> -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include 
> -I/usr/include/uuid -I/usr/include/freetype2 -I/usr/include/libpng16 
>     -DGTK_DISABLE_SINGLE_INCLUDES -DGDK_PIXBUF_DISABLE_SINGLE_INCLUDES 
> -DPLUGIN_DIR=\""/usr/local/lib/gnome-commander/plugins"\" 
> -fno-strict-aliasing -Wall -Wextra -Wundef -Wwrite-strings 
> -Wpointer-arith -Wmissing-declarations -Wredundant-decls 
> -Wno-unused-parameter -Wno-missing-field-initializers -Wformat=2 
> -Wcast-align -Wformat-nonliteral -Wformat-security -Wsign-compare 
> -Wstrict-aliasing -Wshadow -Winline -Wpacked -Wmissing-format-attribute 
> -Wmissing-noreturn -Winit-self -Wmissing-include-dirs 
> -Wunused-but-set-variable -Warray-bounds -Wreturn-type 
> -Wno-overloaded-virtual -Wswitch-enum -Wswitch-default -Werror 
> -Wno-suggest-attribute=format -Wno-error=unused-parameter 
> -Wno-error=missing-field-initializers -Wno-error=overloaded-virtual 
> -Werror=parentheses -Wno-parentheses -Werror=cast-function-type 
> -Wno-cast-function-type -Wno-deprecated-declarations -Wno-inline -g -O2 
> -MT gnome-cmd-advrename-dialog.o -MD -MP -MF 
> .deps/gnome-cmd-advrename-dialog.Tpo -c -o gnome-cmd-advrename-dialog.o 
> gnome-cmd-advrename-dialog.cc
> In file included from ./../gnome-cmd-regex.h:26,
>                   from ./../gnome-cmd-data.h:36,
>                   from gnome-cmd-advrename-dialog.h:24,
>                   from gnome-cmd-advrename-dialog.cc:30:
> ./../utils.h: In function ‘gboolean uri_is_valid(const gchar*)’:
> ./../utils.h:231:33: error: ‘G_URI_FLAGS_NONE’ was not declared in this 
> scope; did you mean ‘G_RESOURCE_FLAGS_NONE’?
>    231 |     return g_uri_is_valid (uri, G_URI_FLAGS_NONE, nullptr);
>        |                                 ^~~~~~~~~~~~~~~~
>        |                                 G_RESOURCE_FLAGS_NONE
> ./../utils.h:231:12: error: ‘g_uri_is_valid’ was not declared in this 
> scope; did you mean ‘uri_is_valid’?
>    231 |     return g_uri_is_valid (uri, G_URI_FLAGS_NONE, nullptr);
>        |            ^~~~~~~~~~~~~~
>        |            uri_is_valid
> [...]

This looks as if glib on your system is not available with at least
version 2.66. This requirement can be seen here in the documentation:
https://docs.gtk.org/glib/flags.UriFlags.html. 

I have actually set this requirement in the file configure.ac in the
variable "GLIB_REQ". I am suprised that the configure step did not
complain before the actual "make". What does the output of your
"autogen.sh" run say about glib? Which version have you installed?

If I get it right the default is 2.64 in Ubuntu 20.04, according to
https://packages.ubuntu.com/focal/libglib2.0-dev

In groovy, version 2.66 it is available:
https://packages.ubuntu.com/groovy/libglib2.0-dev

> Hopefully someone finds this helpful - this is beyond my horizon.
> 
> Best regards
> 
> Stefan

Best
Uwe