Re: [PATCH v2] * builds/windows/ftsystem.c: Correctly detect UWP

[Erin Melucci]

Hi Alexei,

yes, that is correct - that patch is all that is needed to get FreeType to compile using the GDK.

`CreateFileMappingFromApp()` and related calls are exclusive to WINAPI_PARTITION_APP.

A better check would be:

---

WINAPI_FAMILY_PARTITION(WINAPI_PARTITION_APP) && !WINAPI_FAMILY_PARTITION(WINAPI_PARTITION_DESKTOP)

---

but that requires the Windows 10 SDK: I didn't want to break the build for anyone out there using older headers.

On Fri, May 17, 2024 at 5:17 PM Alexei Podtelezhnikov <apodtele@gmail.com> wrote:

Hi Erin,

Just to confirm, you could compile FreeType for Xbox. The stuff in that ifdef was not necessary. Correct?

Alexei

> On May 17, 2024, at 10:25, Erin Melucci <emelucci@opera.com> wrote:
>
> 
> This is not the proper way to detect API availability but it's the least-distuprive change possible to fix building for the GDK (Microsoft Store for games, Xbox).
> ---
>
> Changes since v1:
> * Added missing backslash
>
> ---
>
> builds/windows/ftsystem.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/builds/windows/ftsystem.c b/builds/windows/ftsystem.c
> index 3a56834f6..f8b7126ad 100644
> --- a/builds/windows/ftsystem.c
> +++ b/builds/windows/ftsystem.c
> @@ -197,7 +197,8 @@
>
>
>   /* non-desktop Universal Windows Platform */
> -#if defined( WINAPI_FAMILY ) && WINAPI_FAMILY != WINAPI_FAMILY_DESKTOP_APP
> +#if defined( WINAPI_FAMILY ) && WINAPI_FAMILY != WINAPI_FAMILY_DESKTOP_APP \
> +  && WINAPI_FAMILY != WINAPI_FAMILY_GAMES
>
> #define PACK_DWORD64( hi, lo )  ( ( (DWORD64)(hi) << 32 ) | (DWORD)(lo) )
>
> --
> 2.44.0.windows.1
>
>

--

Erin Melucci | Assistant Engineer, GameMaker Compiler Team

emelucci@opera.com

The information in this email and any attachments is CONFIDENTIAL INFORMATION and is solely for the attention of the intended recipient. If you are not the intended recipient, then you have received this message in error and therefore reading it, copying it, or in any way disclosing its content to any other person is unauthorized. If you have received this message in error, please notify the sender by reply email and then immediately delete this email (including any attachments).