freetype-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: ftbench: last updates


From: Werner LEMBERG
Subject: Re: ftbench: last updates
Date: Mon, 25 Sep 2023 04:20:42 +0000 (UTC)

Hello Ahmet,


sorry for the late reply, I'm travelling right now.

> -Made documentation and comment line (will continue).

Very nice!  Some minor nits, in case you have still time today:

* Please ensure that lines in the documentation are not longer than 78
  characters (`src/tools/ftbench/README`).  Ideally, `README` comes in
  Markdown format, but this is not important.

* Use two spaces after a full dot in documentation (this simplifies
  the search for the beginning of a sentence with some editors like
  Emacs).

* Use `autopep8 -a -a -a` to format `tohtml.py` and do some manual
  editing to also shorten the remaining overlong lines to
  78 characters per line if possible and useful.

* There are some indentation errors in `ftbench.c` (functions
  `test_render`, `test_embolden`, etc.).

* Please synchronize `ftbench.c` with the git version in the
  `freetype-devel` repository (which is a trivial change only).

> In this version of the code, i just didnt splitted iterations into
> chunks, got same results with it.

OK.  Too bad that we couldn't find the real cause for the large time
differences, but hey, this is a GSoC project :-)


  Werner

reply via email to

[Prev in Thread] Current Thread [Next in Thread]