Re: logging support ready for integration into master

[Priyesh kumar]

Hi Werner,

> I've incorporated your patch into the corresponding commit, then doing
> a `git push -f`.

Ok, Great !!

> Which commit (from your GSoC branch)

> are you referring to?

The changes in `include/freetype/internal/ftdebug.h' in commit:

802176853b5418d34704f1705617333145410625 (link) are missing in `logging' branch.

We only have to do the following additions to make it work:

--

diff --git a/include/freetype/internal/ftdebug.h b/include/freetype/internal/ftdebug.h
index e19f9e176..370f0f632 100644
--- a/include/freetype/internal/ftdebug.h
+++ b/include/freetype/internal/ftdebug.h
@@ -123,7 +123,12 @@ FT_BEGIN_HEADER
                                                                                                                             \
             ft_add_tag( dlg_tag );                                                                              \
             if ( ft_trace_levels[FT_TRACE_COMP( FT_COMPONENT )] >= level ) \
-              dlg_trace varformat;                                                                              \
+            {                                                                                                              \
+              if( custom_output_handler != NULL )                                                   \
+                FT_Logging_Callback varformat;                                                       \
+              else                                                                                                       \
+                dlg_trace varformat;                                                                            \
+            }                                                                                                               \
             ft_remove_tag( dlg_tag );                                                                         \
           } while( 0 )

--

Thanks,

Priyesh

On Fri, Dec 4, 2020 at 12:03 AM Werner LEMBERG <wl@gnu.org> wrote:

> The updated code is working fine when we are using the `FT2_DEBUG'
> environment variable with tags(-v / -t / -vt), but without these
> tags I am getting corrupted memory issue with the `features_buf'
> char array in `src/base/ftdebug.c(ft_log_handler)' on both Ubuntu
> and Windows.

D'oh.  I was *sure* that I've tested that...  Thanks for catching.
I've incorporated your patch into the corresponding commit, then doing
a `git push -f`.

> Also, the logic to handle the custom log handler is not present in
> `FT_LOG' macro in `include/freetype/internal/ftdebug.h', have you
> removed that feature, or did you missed to update it?

I seem to have missed it, sorry.  Which commit (from your GSoC branch)
are you referring to?


    Werner