Re: [ft-devel] [PATCH 2/2] [cmake] add support for customized ftsystem on Windows

[Werner LEMBERG]

Hello Azamat,


thanks for your contribution.

Hin-Tak writes:

> This patch set looks wrong - you seem to be special-casing windows,
> copying and forking the two files, src/base/ftdebug.c ,
> src/base/ftsystem.c to builds/windows/ftdebug.c ,
> builds/windows/ftsystem.c , builds/wince/ftdebug.c .

`Wrong' is not the right term, I think.  It's rather...

> I think you need to explain better (1) why special-casing and
> forking is necessary,

... this argument.

> Also, fopen on windows can open non-ascii file names, I think.  It
> is just a byte stream.

The problem is non-ASCII encoded *file names* not the contents of
files.

Azamat, there have been already some other follow-up e-mails on the
e-mail list, so please subscribe and discuss!


   Werner