freetype-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [ft-devel] Experimental: v38 interpreter with minimal backwards comp


From: Nikolaus Waxweiler
Subject: Re: [ft-devel] Experimental: v38 interpreter with minimal backwards compatibility mode and linear advance widths
Date: Wed, 18 May 2016 22:34:27 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0

This is weird. The original logic doesn't fit its comment and will
adjust if either ignore X mode or face SPH compat mode is disabled, not
when both are disabled as suggested.

Maybe this should be !(SUBPIXEL_HINTING_INFINALITY &&
(exc->ignore_x_mode || exc->face->sph_compatibility_mode)).

The original logic at https://github.com/madig/freetype2/commit/ed1d8983f3826124e814145b7556fc8f03ae88df#diff-0508f7c392840b939402aade4cbe3563L5776 says

-      if ( !SUBPIXEL_HINTING                      ||
-           ( !exc->ignore_x_mode                ||
-             !exc->face->sph_compatibility_mode ) )

So the comment and your suggestion match :)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]