[ft-devel] light advance rounding

[Alexei Podtelezhnikov]

let's change the subject..

On Sun, Feb 21, 2016 at 4:19 PM, Nikolaus Waxweiler <address@hidden> wrote:
> Oh and: Light AA seems to change the advance width when it shouldn't?

Like I said, the rounding is done here:
http://git.savannah.gnu.org/cgit/freetype/freetype2.git/tree/src/autofit/afloader.c#n447

Pause for a moment before you can make it conditional:
if ( scaler->render_mode != FT_RENDER_MODE_LIGHT )
 slot->metrics.horiAdvance = FT_PIX_ROUND( slot->metrics.horiAdvance );

When laying out text, the bitmaps are places at pixels, so rounding
happens anyway. Sothe conditional rounding does not matter - there is
no harm in rounding advance in light mode. No?

What concerns me is that the advance rounding is done *after*
rsb_delta is calculated. Is this not a bug?