freetype-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [ft-devel] Discrepancy in FT_MulFix macros and int sizes


From: Werner LEMBERG
Subject: Re: [ft-devel] Discrepancy in FT_MulFix macros and int sizes
Date: Wed, 19 Nov 2014 06:47:10 +0100 (CET)

> It was reported to me by my colleague Doug Felt (CC'ed) that
> FT_MulFix takes FT_Long parameters as defined in freetype.h, but
> several inline implementations of it in ftcalc.h take FT_Int32
> arguments.  I imagine this might have historical reasons, but it's
> something that would be good to address.
> 
> Regardless of the history, this is causing compile warnings on
> x86-64 when parameters of type FT_Fixed (=FT_Long) are passed to
> this function when the inline implementations are used, as integer
> values are truncated from 64bit to 32bit.  Perhaps a patch like this
> (untested):

Applied, thanks.


    Werner



reply via email to

[Prev in Thread] Current Thread [Next in Thread]