Re: [ft-devel] WIP PATCH: clang static analyzer and warning fixes

[Alexei Podtelezhnikov]

On Tue, Mar 18, 2014 at 2:37 AM, Werner LEMBERG <address@hidden> wrote:

> The patch 0004 is false positive.  The variable 'hit' is set to zero
> when entering the loop so 'p_last' and 'p_first' are assigned almost
> immediately.

Thanks for the analysis.  However, initializing doesn't hurt, and
pacifying one of the most used compilers is probably a good thing.

It is ugly. First we initialize to 0, then twenty lines down we reassign both variables to -1. It looks like we do not know what we are doing. If the -1 is of any special fallback meaning, I would use it in the initialization and drop lines 575 and 573. Any objection?