Re: [ft-devel] WIP PATCH: clang static analyzer and warning fixes

[Sean McBride]

On Tue, 4 Mar 2014 04:50:06 +0100, Werner LEMBERG said:

>> Here's another 2 patches to fix most of the remaining warnings.
>
>Thanks, I've applied the first one (and sorry for forgetting git
>commit's `--author' flag).

No worries!

>However, I strongly dislike the second one.

No problem, I separated them because I thought you might dislike it...

>IMHO, this is wrong analysis of clang (BTW, what exactly does it
>report?).

src/bdf/bdflib.c:694:5: Value stored to 'end' is never read

src/truetype/ttgload.c:2349:5: Value stored to 'error' is never read

Attached is a more straightforward fix.

Cheers,

--
____________________________________________________________
Sean McBride, B. Eng                 address@hidden
Rogue Research                        www.rogue-research.com
Mac Software Developer              Montréal, Québec, Canada

0001-Removed-two-minor-dead-stores-to-fix-clang-analyzer-.patch
Description: Binary data