Re: [ft-devel] MSVC build woes !

[John Emmas]

On 12/06/2013 10:10, Werner LEMBERG wrote:
> I've again disabled MSVC warning C4127 in the git
> repository; especially after looking at
>
>    https://svn.boost.org/trac/boost/wiki/Guidelines/WarningsGuidelines
>
> I now believe that the original solution of disabling this warning
> completely is the right thing.
>
> Theoretically, there shouldn't be any warnings now in an MSVC build.

Thanks for all your hard work Werner and for everybody's input on this.  
I only spotted one problem....

In 'ftserv.h' you've implemented the pragma like this:-

        #if defined( _MSC_VER )      /* Visual C++ (and Intel C++) */
          /* We disable the warning `conditional expression is */
          /* constant' in order to compile cleanly with the maximum */
          /* level of warnings. */
        #pragma warning( push )
        #pragma warning( disable : 4127 )
        #endif /* _MSC_VER */

        // [ ... ] rest of header file

        #if defined( _MSC_VER )
        #pragma warning( pop )
        #endif

But of course that doesn't work - because the 'pop' will re-enable the 
warning as soon as that header file finishes processing.  By the time 
the compiler wends its way back to the original source file, warning 
4127 is enabled again.  The way you did it in 'ftdebug.h' works fine though.

John