freetype-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [ft-devel] FT_Bitmap_Convert and 1bpp bitmaps


From: Werner LEMBERG
Subject: Re: [ft-devel] FT_Bitmap_Convert and 1bpp bitmaps
Date: Tue, 16 Mar 2010 09:21:15 +0100 (CET)

>> First of all "source->width >> 3" is 0 for widths < 8 and the whole
>> loop is skipped. So we need to make the condition j >= 0.
>
> This is definitely a bug.

Oops!  I think the old code was correct!  Here, everything but the
last loop is handled – you always have full multiples of 8:

>          for ( j = source->width >> 3; j > 0; j-- )
>            [...]

Later on the remaining pixels are handled:

>          j = source->width & 7;
>          [...]


    Werner

reply via email to

[Prev in Thread] Current Thread [Next in Thread]