Re: [ft-devel] Bug in the font or bug in freetype?

[mpsuzuki]

Dear Werner,

On Sat, 23 Jan 2010 15:18:55 +0100 (CET)
Werner LEMBERG <address@hidden> wrote:
>BTW, in a mail you've mentioned that you want to take care of this
>bug:
>
>  http://lists.gnu.org/archive/html/freetype-devel/2009-12/msg00022.html
>
>Is there any progress?

Oops, I'm quite sorry, I've slipped working for this issue,
due to the lack of sample to reproduce the problem. In fact,
Jimmy said "all Type42 font does not work", but Type42 fonts
converted by fontforge works well in my environment.

Since 2009-Jan-05, the incremental font interface has been
enabled by default, so his patch should be following. I've
checked that it does not reopen Savannah bug #25010, in
both cases of incremental font interfaces enabled/disabled.

Could I commit this patch to GIT head?

Regards,
mpsuzuki


diff --git a/builds/unix/install-sh b/builds/unix/install-sh
old mode 100644
new mode 100755
diff --git a/src/truetype/ttgload.c b/src/truetype/ttgload.c
index 74fb73d..cd11c12 100644
--- a/src/truetype/ttgload.c
+++ b/src/truetype/ttgload.c
@@ -1278,13 +1278,9 @@
 
     if ( loader->byte_len > 0 )
     {
-#ifdef FT_CONFIG_OPTION_INCREMENTAL
       /* for the incremental interface, `glyf_offset' is always zero */
       if ( !loader->glyf_offset                        &&
            !face->root.internal->incremental_interface )
-#else
-      if ( !loader->glyf_offset )
-#endif /* FT_CONFIG_OPTION_INCREMENTAL */
       {
         FT_TRACE2(( "no `glyf' table but non-zero `loca' entry\n" ));
         error = TT_Err_Invalid_Table;