[ft-devel] Re: table_info service and ftpatent module

[Werner LEMBERG]

> Dear Turner,

Sorry for the late reply, and I'm only Werner, not David :-)

> During the checking for Atari port, I find a strange call of
> table_info service in ftpatent module.  [...]

Definitely a bug.

> Yet I've not checked whether ftpatent works correctly (and if so,
> why it can works), but I guess the implementation of ftpatent should
> be improved.

Hehe, nice words for a for faulty implementation.

> There might be 3 directions:
> 
> A) extend table_info service in sfnt driver to return offset.
>    it is most easiest, but it introduces an asymmetry between
>    table_info service and public API FT_Sfnt_Table_Info():
> 
>    FT_EXPORT( FT_Error )
>    FT_Sfnt_Table_Info( FT_Face    face,
>                        FT_UInt    table_index,
>                        FT_ULong  *tag,
>                        FT_ULong  *length );
> 
> B) introduce new service to obtain an offset (and others, if
>    required) to the table in sfnt stream. 
> 
> C) move some part of ftpatent to sfnt driver to use sfnt-specific
>    internal data structures and internal functions.
> 
> Which is the best direction?

I suggest (A), with a proper comment.  In case more than this single
function needs the offset it is still easy to revert (A) and implement
(B).


    Werner