[ft-devel] issues found when porting to FreeType 2.3.7

[Graham Asher]

I'm going to list all the other issues I find while moving to FreeType 2.3.7
here.

1. Spelling errors in comments.
The word 'synthetize' doesn't exist and should be corrected to 'synthesize'
in two places in ftoption.h.

2. The function open_face in ftobjs.c crashes if 'face' is not created. The
fix is to test for 'face' being non-null in the error-handling section.
Change

      destroy_charmaps( face, memory );
      if ( clazz->done_face )
        clazz->done_face( face );

to

if ( face)
  {
      destroy_charmaps( face, memory );
      if ( clazz->done_face )
        clazz->done_face( face );
  }

3. The code in pstables.h needs to be enclosed by

#ifdef FT_CONFIG_OPTION_ADOBE_GLYPH_LIST ... #endif

so that the large tables and the functions are not compiled unnecessarily.

4. In sfobjs.c, all uses of psnames_error need to be enclosed in

#ifdef TT_CONFIG_OPTION_POSTSCRIPT_NAMES .. #endif

6. The following warnings are displayed when ttpost.c is compiled:

s:\src\freetype-2.3.7\src\sfnt\ttpost.c(463) : warning C4090: '=' :
different 'const' qualifiers
s:\src\freetype-2.3.7\src\sfnt\ttpost.c(470) : warning C4090: '=' :
different 'const' qualifiers
s:\src\freetype-2.3.7\src\sfnt\ttpost.c(490) : warning C4090: '=' :
different 'const' qualifiers
s:\src\freetype-2.3.7\src\sfnt\ttpost.c(510) : warning C4090: '=' :
different 'const' qualifiers

They can be fixed by changing

*PSname = MAC_NAME to

*PSname = (FT_String*)MAC_NAME

on those four lines. A better fix would propagate the constness to the
function signature and any callers.

Best regards,

Graham